-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLA check to all module builds #792
Comments
ah, here's some prior art: scala/vscode-scala-syntax#170 oh but darn:
:-/ regardless, a starting point I should look and see if the copy of the script in vscode-scala-syntax has diverged from the Dotty one, https://github.com/lampepfl/dotty/blob/master/project/scripts/check-cla.sh |
I made a change to the Dotty CLA check a few months ago, after GitHub started requiring workflow approval for new contributors. Before the change, the CLA check would run on the user who approved the workflow rather than the user who opened the PR. |
Also, I think the Dotty CLA check was originally lifted from https://github.com/scala-js/scala-js/blob/master/ci/check-cla.sh and they may have diverged. |
this will be re-added uniformly across modules later; see scala/scala-dev#792
this will be re-added uniformly across modules later; see scala/scala-dev#792
e.g. scala-collection-compat had an
admin/checkCLA.sh
script that did this, but the details were Travis-CI-specificI don't know if we were consistent before in doing this in all module repos, but in any case, once all the repos are on GitHub Actions, surely it will be easy to copy Actions code for the CLA check from somewhere — perhaps the Dotty repo, or some Lightbend repo
(does the CLA check exist as its own standalone action, such that it could be added to
ci.yml
as a one-liner, rather than copy/pasting implementation details? that would be ideal)The text was updated successfully, but these errors were encountered: