Performance improvements: avoid boxing and needless string to name conversion #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retronym
force-pushed
the
faster/misc
branch
2 times, most recently
from
c8ef754 to
4fb0b75
Compare
retronym
changed the title
retronym
force-pushed
the
faster/misc
branch
3 times, most recently
from
e598f87 to
df7f6a8
Compare
retronym
force-pushed
the
faster/misc
branch
2 times, most recently
from
3f56e88 to
f7516a7
Compare
- Introduce a per-Global store of names - Avoid double freshening names - Use $async$ in all names to avoid clashes with, e.g. lambda lifted methods.
Member
Author
|
Simplifications to dead state elimination and generation of .dot visualiations of the state machine moved to #198 |
viktorklang
reviewed
May 4, 2018
| private val nameCache = new util.WeakHashMap[Object, AsyncNames[_]]() | ||
| def apply(c0: reflect.macros.Context, base: AsyncBase)(body0: c0.Tree): AsyncMacro { val c: c0.type } = { | ||
| import language.reflectiveCalls | ||
| val asyncNames0 = nameCache.synchronized[AsyncNames[_]] { |
Contributor
There was a problem hiding this comment.
Why synchronized + computeIfAbsent?
Member
Author
There was a problem hiding this comment.
I got rid of this map altogether #194 as I think this was leaky anyway.
Member
Author
|
Superceded by #194 |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.