Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of Collections Overview to Brazilian Portuguese. #341

Merged
merged 3 commits into from
Aug 19, 2015

Conversation

douglasjose
Copy link
Contributor

I started the translation of the Collections documentation to Brazilian Portuguese. Are the changes I made in the expected format?

Thanks,

Douglas

@SethTisue
Copy link
Member

@heathermiller can you suggest a reviewer for this?

@SethTisue
Copy link
Member

@douglasjose are you still out there and interested? sorry for the long delay — we have been shorthanded.

@heathermiller
Copy link
Member

So the answer is yes, that the changes appear to be in the correct format. One can also generate the site to see if it all works. Though if this remains an incomplete stub (i.e. if no one picks it up), I'd suggest to eventually close the PR.

In terms of a potential reviewer – the only Brazilian Portuguese speaker I know that also knows (everything about) Scala is @dcsobral

@SethTisue
Copy link
Member

good to hear the format is right. I'll also mention @pedrofurla

@douglasjose
Copy link
Contributor Author

@SethTisue, I'd be glad to help with whatever I can.

@pedrofurla
Copy link

Hello Everybody,

I'll read it as soon as I get time, which is likely to be only on late friday/saturday.

I will mention @jcranky, he is the São Paulo SUG organizer and is (was?) writing a book about Scala.


###### Contribuição de {{ page.by }}

Para muitos, o novo framework de coleções é a novidade mais significante da release Scala 2.8. Scala tinha coleções antes (e na verdade o novo framework é amplamente compatível com o antigo), mas apenas a versão 2.8 é que provê um framwork único, uniforme e compreensivo para tipos de coleções.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

framework

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fixed.

@jcranky
Copy link

jcranky commented Jul 28, 2015

Other than the small typo above, I see no problems in the translation (although I read it quickly only)


**Rápidas:** Operações de coleções são ajustadas e otimizadas em suas bibliotecas. E o resultado é que o uso de coleções é normalmente bastante eficiente. Talvez você consiga resultados um pouco melhores com estruturas de dados e operações cuidadosamente ajustadas, mas você também pode ter um resultado muito pior se tomar decisões de implementação não tão ideais durante este processo. Além disso, recentemente as coleções foram adaptadas para execução paralela em _cores_ múltiplos. Coleções paralelas suportam as mesmas operações que as seqüenciais, de forma que não é necessário aprender novas operações e o código não precisa ser reescrito. Você pode converter uma coleção seqüencial em uma paralela simplesmente invocando o método `par`.

**Universal:** Coleções provêm as mesmas operações sobre qualquer tipo onde faz sentido que elas existam, de forma que você possa construir muitas coisas com um vocabulário de operações relativamente pequeno. Por exemplo, uma _string_ é conceitualmente uma seqüência de caracteres. Consequentemente, em coleções Scala, _strings_ suportam todas as operações de seqüências. O mesmo vale para _arrays_.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong conjugation of the "Prover" veb: Coleções provêm. correct: Coleções proveem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Will fix.

@pedrofurla
Copy link

LGTM. @heathermiller @SethTisue, please also have a look at the last paragraph of the EN version of this doc.:
This document provides an in depth discussion of the APIs of the Scala collections classes from a user perspective. They take you on a tour of all the fundamental classes and the methods they define.
"They" in the second phrase seems pretty wrong.

SethTisue added a commit that referenced this pull request Aug 19, 2015
Translation of Collections Overview to Brazilian Portuguese.
@SethTisue SethTisue merged commit 857b637 into scala:master Aug 19, 2015
@SethTisue
Copy link
Member

thank you Douglas for the submission, and thank you Pedro and jcranky for helping get it merged.

I'll submit a second PR fixing the English version.

@douglasjose
Copy link
Contributor Author

Looks like there is something wrong with the way the links to different languages have been generated. I attached a screenshot of how I'm seeing http://docs.scala-lang.org/overviews/collections/introduction.html rendered:

collections-links

@SethTisue
Copy link
Member

ugghhh... when I build the site locally, it works fine :-(

(and I did bundle install, bundle exec jekyll serve, I'm not just running some random version of jekyll)

not sure what to think

@SethTisue
Copy link
Member

@heathermiller you and Jekyll are old friends... any guesses on this, or suggestions on who else could take a look?

@heathermiller
Copy link
Member

I don't think it's a good idea advertise a translation of a document that is only like 6% translated... I'm not sure what specifically the issue is, but the liquid scripts assume a complete document. There are likely two "num: 1" stubs...

I'd rather revert this PR until the full translation is complete.

@SethTisue
Copy link
Member

ok, reverted in 15c478c

contributors: a full translation would still be very welcome, of course!

@heathermiller
Copy link
Member

Seconded! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants