Improve precision of IDB API and add tests #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
wait up i'll rebase |
japgolly
force-pushed
the
topic/idb
branch
2 times, most recently
from
a25e5b7 to
1023e0c
Compare
Contributor
Author
|
Ok cool, rebased, tweaked, and ready for review |
armanbilge
reviewed
Sep 7, 2021
Member
armanbilge
left a comment
armanbilge
left a comment
There was a problem hiding this comment.
This looks pretty awesome, adding type parameters to this API is obviously a big win. Most just questions since I'm not so familiar with IDB.
Acording to https://developer.mozilla.org/en-US/docs/Web/API/IDBObjectStore/getAll#parameters the max count is 2^32
* Stop using js.Any in IDB * Replace all uses of Any with something more specific * Improve type safety of various methods * Add missing API * Add more ScalaDoc * Change constants to match the JS names
Contributor
Author
|
Ok @armanbilge I've updated this again, and addressed all the feedback. You can read the expanded commit messages for the changes. |
armanbilge
approved these changes
Sep 9, 2021
Member
armanbilge
left a comment
armanbilge
left a comment
There was a problem hiding this comment.
Thanks for your massive efforts on this!! Learned a lot too.
Contributor
Author
|
Awesome! Thanks for the lengthy review too |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.