Skip to content

Adds the inital files for the scalacheck exercises #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fedefernandez merged 2 commits into from
Jul 4, 2016
Merged

Adds the inital files for the scalacheck exercises #1

fedefernandez merged 2 commits into from
Jul 4, 2016

Conversation

@fedefernandez
Copy link
Contributor

@fedefernandez fedefernandez commented Jul 4, 2016

Please @dialelo @raulraja could you review? Thanks

raulraja
raulraja reviewed Jul 4, 2016
View reviewed changes
build.sbt Outdated
),
libraryDependencies ++= Seq(
"org.scalatest" %% "scalatest" % "2.2.4",
"com.fortysevendeg" %% "github4s" % "0.5",
Copy link

@raulraja raulraja Jul 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not need here anymore since @dialelo just merged a fix for this

@raulraja
Copy link

raulraja commented Jul 4, 2016

Minor comments LGTM!

This PR:
486e7f2 
  - Removes github4s dependency
  - Upgrades to the new scala-exercises version
  - Use https for the scala-exercises url
@fedefernandez fedefernandez merged commit bf7642a into master Jul 4, 2016
@fedefernandez fedefernandez deleted the fede-initial-project-structure branch July 4, 2016 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fedefernandez @raulraja