Evaluator Server Update #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvellido
requested changes
Sep 18, 2019
calvellido
requested changes
Sep 18, 2019
server/src/test/scala/org/scalaexercises/evaluator/EvaluatorSpec.scala
Outdated
Show resolved
Hide resolved
server/src/test/scala/org/scalaexercises/evaluator/EvalEndpointSpec.scala
Outdated
Show resolved
Hide resolved
juanpedromoreno
requested changes
Sep 18, 2019
server/src/main/scala/org/scalaexercises/evaluator/services.scala
Outdated
Show resolved
Hide resolved
calvellido
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved compilation problems caused by the dependencies update. This PR does not solve compilation problems in the test module, this will be added in a future PR.
This evaluator resolves dependencies, compiles and executes code using a REST API. This request code has been used to test the evaluator using postman:
{ "code": "{import cats.effect._\nimport cats.syntax.all._\nimport fetch._\nimport cats.data.NonEmptyList\n\ntrait DataSource[F[_], Identity, Result]{\n def data: Data[Identity, Result]\n\n def CF: Concurrent[F]\n\n def fetch(id: Identity): F[Option[Result]]\n\n def batch(ids: NonEmptyList[Identity]): F[Map[Identity, Result]]\n}\ntype UserId = Int\ncase class User(id: UserId, username: String)\n\ndef latency[F[_] : Concurrent](msg: String): F[Unit] = for {\n _ <- Sync[F].delay(println(s\"--> [${Thread.currentThread.getId}] $msg\"))\n_ <- Sync[F].delay(Thread.sleep(100))\n _ <- Sync[F].delay(println(s\"<-- [${Thread.currentThread.getId}] $msg\"))\n} yield ()}", "resolvers": [ "https://oss.sonatype.org/content/repositories/snapshots", "https://oss.sonatype.org/content/repositories/public" ], "dependencies": [ { "groupId": "com.47deg", "version": "1.2.0", "artifactId": "fetch_2.11" } ] }Remaining parts to finish the evaluator update are the solution of compilation problems in the server/test module and the creation of a new http client for the client module.