Pass scalac flags to the endpoint #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominv
changed the title
raulraja
approved these changes
Mar 13, 2017
Contributor
raulraja
left a comment
raulraja
left a comment
There was a problem hiding this comment.
LGTM but let's get rid of all code and config that is not in use before this gets merged in
| loaderio.verificationToken=${?LOADERIO_VERIFICATION_TOKEN} | ||
| loaderio.verificationToken=${?LOADERIO_VERIFICATION_TOKEN} | ||
|
|
||
| allowed.compiler{ |
|
|
||
| val AllowedCompilerFlags = "allowed.compiler.flags" | ||
|
|
||
| val allowedCompilerFlags = if (config.hasPath(AllowedCompilerFlags)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #48 and adds the ability to pass scalac flags to the endpoint including the necessary tests.
It also adds the macroparadise plugin as a compiler plugin to the evaluator.
@raulraja could you please review?
Thanks!