Skip to content

Conversation

@juanpedromoreno
Copy link
Contributor

Forgotten apply method in the previous PR.

Please, @raulraja @dialelo could you review? thanks!

@ghost
Copy link

ghost commented Aug 12, 2016

👍 LGTM, we could also use the FiniteDuration type to not allow infinite timeouts.

@juanpedromoreno
Copy link
Contributor Author

Good point @dialelo , definitely: #24

@juanpedromoreno juanpedromoreno merged commit 74e52ef into master Aug 12, 2016
@juanpedromoreno juanpedromoreno deleted the jp-fix-eval-client-api-params branch August 12, 2016 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants