Closed
Conversation
vikramjakhr
force-pushed
the
staging-release-v4.0.3
branch
from
280dca9 to
677fa2e
Compare
hstone-scala
added a commit
that referenced
this pull request
Jan 26, 2021
vlakshmanan-scala
pushed a commit
that referenced
this pull request
Apr 4, 2024
TYPE: bug fix KEYWORDS: unary operator, Noahmp SOURCE: Internal DESCRIPTION OF CHANGES: Problem: Found more occurrences of `a* -b` in Noahmp. A space is in between `*` and `-1`. OK even for Cray, but it is still non-standard. Solution: The same solution is applied: add parentheses: `a * (-b)`. ASSOCIATED REPOSITORY CHANGE: NCAR/noahmp#33 LIST OF MODIFIED FILES: modified: phys/noahmp TESTS CONDUCTED: 1. More code is fixed. 2. Jenkins tests are all passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use this template to give a detailed message describing the change you want to make to the code.
If you are unclear on what should be written here, see https://github.com/wrf-model/WRF/wiki/Making-a-good-pull-request-message for more guidance
The title of this pull request should be a brief "purpose" for this change.
--- Delete this line and those above before hitting "Create pull request" ---
TYPE: choose one of [bug fix, enhancement, new feature, feature removed, no impact, text only]
KEYWORDS: approximately 3 to 6 words (more is always better) related to your commit, separated by commas
SOURCE: Either "developer's name (affiliation)" .XOR. "internal" for a WRF Dev committee member
DESCRIPTION OF CHANGES: One or more paragraphs describing problem, solution, and required changes.
ISSUE: For use when this PR closes an issue. For issue number 123
LIST OF MODIFIED FILES: list of changed files (use
git diff --name-status masterto get formatted list)TESTS CONDUCTED: Explicitly state if a WTF and or other tests were run, or are pending. For more complicated changes please be explicit!
RELEASE NOTE: Optional, as appropriate. Delete if not used. Included only once for new features requiring several merge cycles. Changes to default behavior are also note worthy.