Override subtasks as subtasks, not tasks #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the hardhat help printer was including these tasks as top-level tasks rather than excluding them from the output like sub-tasks get excluded: ``` $ yarn hardhat yarn run v1.22.11 $ /home/gene/dev/geneAum/hardhat-empty/node_modules/.bin/hardhat 183902c7-780d-45b2-8153-d82bdca11490 Hardhat version 2.5.0 Usage: hardhat [GLOBAL OPTIONS] <TASK> [TASK OPTIONS] GLOBAL OPTIONS: --config A Hardhat config file. --emoji Use emoji in messages. --help Shows this message, or a task's help if its name is provided --max-memory The maximum amount of memory that Hardhat can use. --network The network to connect to. --show-stack-traces Show stack traces. --tsconfig Reserved hardhat argument -- Has no effect. --verbose Enables Hardhat verbose logging --version Shows hardhat's version. AVAILABLE TASKS: accounts Prints the list of accounts check Check whatever you need clean Clears the cache and deletes all artifacts compile Compiles the entire project, building all artifacts compile:solidity:get-compilation-job-for-file compile:solidity:get-compiler-input console Opens a hardhat console coverage Generates a code coverage report for tests flatten Flattens and prints contracts and their dependencies help Prints this message node Starts a JSON-RPC server on top of Hardhat Network run Runs a user-defined script after compiling the project test Runs mocha tests typechain Generate Typechain typings for compiled contracts verify Verifies contract on Etherscan To get help for a specific task run: npx hardhat help [task] Done in 2.82s. ``` After these changes, these sub-tasks are being hidden properly: ``` $ yarn hardhat yarn run v1.22.11 $ /home/gene/dev/geneAum/hardhat-empty/node_modules/.bin/hardhat 183902c7-780d-45b2-8153-d82bdca11490 Hardhat version 2.5.0 Usage: hardhat [GLOBAL OPTIONS] <TASK> [TASK OPTIONS] GLOBAL OPTIONS: --config A Hardhat config file. --emoji Use emoji in messages. --help Shows this message, or a task's help if its name is provided --max-memory The maximum amount of memory that Hardhat can use. --network The network to connect to. --show-stack-traces Show stack traces. --tsconfig Reserved hardhat argument -- Has no effect. --verbose Enables Hardhat verbose logging --version Shows hardhat's version. AVAILABLE TASKS: accounts Prints the list of accounts check Check whatever you need clean Clears the cache and deletes all artifacts compile Compiles the entire project, building all artifacts console Opens a hardhat console coverage Generates a code coverage report for tests flatten Flattens and prints contracts and their dependencies help Prints this message node Starts a JSON-RPC server on top of Hardhat Network run Runs a user-defined script after compiling the project test Runs mocha tests typechain Generate Typechain typings for compiled contracts verify Verifies contract on Etherscan To get help for a specific task run: npx hardhat help [task] Done in 2.77s. ```
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 22 22
Lines 986 986
=======================================
Hits 973 973
Misses 13 13
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the hardhat help printer was including these tasks as top-level tasks rather than excluding them from the output like sub-tasks get excluded:
After these changes, these sub-tasks are being hidden properly: