JUnitXmlReportPlugin generates invalid testcase name

[Pyppe]

It seems that in certain cases an invalid test-case name is generated in the JUnit XML output.

steps

This is one arbitrary example demonstrating the issue:

  "This example" should {
    "given <VER.123 FOOBAR> yield <ver.123 foobar>" in {
      ok
    }
  }

problem

With this example (using specs2 3.8.6) the generated JUnit XML contains the following test-case:

<testcase classname="org.example.ExampleSpec" name="123 foobar&gt;" time="0.006">
</testcase>

expectation

Now, obviously the correct XML should be as follows:

<testcase classname="org.example.ExampleSpec" name="This example should::given &lt;VER.123 FOOBAR&gt; yield &lt;ver.123 foobar&gt;" time="0.006">
</testcase>

notes

• See https://github.com/Pyppe/specs2-junitxml-testcase-name as a simple project demonstrating the issue.
• I initially reported this in Invalid testcase name in generated JUnit XML etorreborre/specs2#537, but @etorreborre graciously debugged it to be part of sbt's JUnitXmlReportPlugin.

[Pyppe]

Just by looking at the code;

sbt/testing/src/main/scala/sbt/JUnitXmlTestsListener.scala

Line 73 in d9cc0c2

case selector: TestSelector=> selector.testName.split('.').last

looks fishy:

case selector: TestSelector=> selector.testName.split('.').last

[maichler]

This issue bothers me as well!

If I understand the API documentation of TestSelector correctly, testName() is supposed to just return the test name itself.

IMHO post processing of testName() in JUnitXmlTestsListener is a bug and should be removed.

Any thoughts ?