-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for relocatable RPMs #661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have done a manual test with the following steps:
The manual test has been done on Redhat 7. |
Using Otherwise LGTM - @muuki88 - WDYT? |
Save the value of `RPM_INSTALL_PREFIX` into application's sysconfig file. Upon application start up, look for this value, else use the `chdir` value supplied via sbt templates.
fsat
force-pushed
the
relocatable-rpm-support
branch
from
September 4, 2015 05:07
9e1f7d8
to
e6a1e13
Compare
Used |
fsat
changed the title
WIP - DON'T MERGE - Support for relocatable RPMs
Support for relocatable RPMs
Sep 4, 2015
Manual test also done successfully on Redhat 6. |
LGTM. |
fsat
added a commit
to fsat/sbt-native-packager
that referenced
this pull request
Sep 7, 2015
This test asserts the behaviour added by sbt#661
This was referenced Sep 11, 2015
littleRoundaer
pushed a commit
to littleRoundaer/sbt-native-packager
that referenced
this pull request
Jul 19, 2022
This test asserts the behaviour added by sbt/sbt-native-packager#661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save the value of
RPM_INSTALL_PREFIX
into application's sysconfig file.Upon application start up, look for this value, else use the
chdir
value supplied via sbt templates.I have two options in detecting where the RPM package is installed.
Option 1: Use
RPM_INSTALL_PREFIX
provided during installation processThe
RPM_INSTALL_PREFIX
environment variable is only provided during the install time. This value would need to be persisted so it can be retrieved during application start-up.Option 2: Use rpm command
The command
rpm -q --queryformat "%{INSTPREFIXES}" ${{app_name}}
will print out the location where the package is installed. This command works for both Redhat 6 and 7.I have decided to go with Option 1 because we are using the values provided to us by the operating system instead of trying to deduce this value ourselves.
The downside of this approach is:
RPM_INSTALL_PREFIX
in the/etc/sysconfig/${{app_name}}
.@muuki88 and @edwardcallahan - can I get your thoughts on my approach please? Happy to change if you think Option 2 is a better way to move forward.