Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional tests and fix for #563. #566

Merged
merged 1 commit into from
Apr 29, 2015
Merged

Additional tests and fix for #563. #566

merged 1 commit into from
Apr 29, 2015

Conversation

metasim
Copy link
Member

@metasim metasim commented Apr 28, 2015

No description provided.

@muuki88
Copy link
Contributor

muuki88 commented Apr 29, 2015

Travis as problems again :/

@muuki88
Copy link
Contributor

muuki88 commented Apr 29, 2015

Code LGTM

@kardapoltsev
Copy link
Member

LGTM too except println (:
You could use streams.log instead.

@metasim
Copy link
Member Author

metasim commented Apr 29, 2015

@kardapoltsev println was just in the scripted test, as it swallows log output by default, and more feedback was needed there. BTW, I was having problems with scripted; calling > clean wasn't cleaning, and calling > set maintainer := "" caused an error. Anyone know where to file bugs against scripted?

muuki88 added a commit that referenced this pull request Apr 29, 2015
@muuki88
Merge pull request #566 from metasim/metasim/fix-563
cff7219 
Additional tests and fix for #563.
@muuki88 muuki88 merged commit cff7219 into sbt:master Apr 29, 2015
@muuki88 muuki88 mentioned this pull request Apr 29, 2015
Closed
@metasim metasim deleted the metasim/fix-563 branch May 12, 2015 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
jdkpackager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metasim @muuki88 @kardapoltsev