Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposition for #385 -- adding raw commands #488

Closed
wants to merge 2 commits into from

Conversation

andypetrella
Copy link

Hello,

This is a small PR for the issue #385. I did it rather straightforward because it's a rather broad need.

I introduced Raw for a partial script to be included in the Dockerfile then two keys:

  • dockerRawWithOriginalUser for commands before USER $daemonUser
  • dockerRawWithDaemonUser for commands after USER $daemonUser

FYI: I need it the for my SparkNotebook for which I'd like to be able to map volumes from the host (for instance).
I had a question regarding this and I'm struggling with it for two days, and actually a solution would be to use a less restrictive user.

Note: I'm sure I did it on the right branch (... from master → 0.7, and there is a 0.8 one I see).

tell me what you think
thanks
andy

@lightbend-cla-validator

Hi @andypetrella,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:

http://typesafe.com/contribute/cla

@muuki88 muuki88 added the docker label Feb 13, 2015
@muuki88
Copy link
Contributor

muuki88 commented Feb 13, 2015

Thanks for your pull request :) We are currently changing the docker internals here #486
I think you can now achieve your goal with the new exposed API.

dockerCommands := {
  val cmds = dockerCommands.value
  // add, filter, remove docker commands as you like
  cmds
}

The new documentation gives a bit more details.

@andypetrella
Copy link
Author

@muuki88 ah great, so should I work on this branch atm?

Also, do you have any mechanism (shortcuts) to create user and to set him the rights to execute the packaged app (a play one in my case)?

Thanks a lot for the information.
andy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants