Fix for RPM error "Unable to open temp file" #228 #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defaine _tmppath when calling rpmbuild
|
Hi @grahamar, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement: |
define _tmppath when calling rpmbuild using temporary directory
| @@ -76,7 +76,8 @@ object RpmHelper { | |||
| "-bb", | |||
| "--target", spec.meta.arch + '-' + spec.meta.vendor + '-' + spec.meta.os, | |||
| "--buildroot", buildRoot.getAbsolutePath, | |||
| "--define", "_topdir " + workArea.getAbsolutePath | |||
| "--define", "_topdir " + workArea.getAbsolutePath, | |||
| "--define", "_tmppath " + IO.createTemporaryDirectory.getAbsolutePath | |||
There was a problem hiding this comment.
Hmm, you may want to make sure this is cleaned later, like "deleteOnClose" or whatever.
define _tmppath when calling rpmbuild using temporary directory and cleanup temporary directory afterwards.
|
I tested this on CentOS 6.5 and works fine. Thanks @grahamar :) |
|
No problem! I signed the CLA and I tested on Mac OSX Mavericks :) |
muuki88
added a commit
that referenced
this pull request
Apr 19, 2014
Fix for RPM error "Unable to open temp file" #228
|
Nice. Mac seems to have some issue here and there with rpm :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
define _tmppath when calling rpmbuild