Handle spaces in java arguments properly #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith play settings. * Default to sbt 0.13 build now * Remove reference to released version of sbt-native-packager in test-project.
* Add appropriate quotes to make sure java arguments (-D) are correctly handled. * Add a test to validate the fix works Fixes #205
|
Also @aparkinson @muuki88 @kardapoltsev notice that this bumps the default build to sbt 0.13. I think after the 0.7.0 release we'll stop supporting sbt 0.12 for "trunk" of this plugin, but the 0.7.0 series will support it. |
|
LGTM |
|
Fine by me |
jsuereth
added a commit
that referenced
this pull request
Apr 1, 2014
Handle spaces in java arguments properly
|
Thanks again. Any ETA on a release so that I may bring this into Play? |
|
"Soon" there will be ab RC2. Working on docs all day today/tomorrow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review/use by @huntc