Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error publishing docs #1619

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Fix error publishing docs #1619

merged 4 commits into from
Jun 19, 2024

Conversation

dwickern
Copy link
Collaborator

@dwickern dwickern commented Jun 18, 2024

Fixes #1597
Supersedes #1618

I'm opening this PR from this repository instead of my fork. Hopefully that will fix the permissions issue.

@dwickern
Copy link
Collaborator Author

Well, it's a different error at least

[error] remote: error: GH006: Protected branch update failed for refs/heads/gh-pages.        
[error] remote: error: Required status check "typesafe-cla-validator" is expected.        
[error] To https://github.com/sbt/sbt-native-packager
[error]  ! [remote rejected]   gh-pages -> gh-pages (protected branch hook declined)
[error] error: failed to push some refs to 'https://github.com/sbt/sbt-native-packager'
[error] Nonzero exit code (1) running git.
[error] (ghpagesPushSite) Nonzero exit code (1) running git.

@dwickern dwickern force-pushed the fix-published-docs branch 2 times, most recently from ed62849 to 19c0bee Compare June 18, 2024 22:23
@dwickern
Copy link
Collaborator Author

Successfully published! 🎉 https://www.scala-sbt.org/sbt-native-packager/

I used b6c9142 to test publishing from this PR. I'll drop the commit before merging. Importantly, I had to open this PR from the main repo and not my fork in order for Github Actions to have write permission. You can see the permissions granted by GITHUB_TOKEN in the "Set up job" phase of the Github Actions job.

I made the following changes outside of this PR:

  • Removed branch protection (e.g. must sign CLA) from gh-pages branch
  • Removed KNOWN_HOSTS and SSH_KEY secrets (in order to clean up the now unused secrets)

@dwickern dwickern marked this pull request as ready for review June 19, 2024 17:58
@dwickern dwickern requested a review from muuki88 June 19, 2024 18:57
publish:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to use this old version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason, I just copied it from release.yml

@muuki88
Copy link
Contributor

muuki88 commented Jun 19, 2024

Amazing work 🙏💪thanks a lot

@muuki88 muuki88 merged commit fdf809d into master Jun 19, 2024
16 checks passed
@muuki88 muuki88 deleted the fix-published-docs branch June 19, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sbt ghpagesPushSite failed for the 1.10.0 release
2 participants