Fix #37 Adding meaningful logging, when packageDescription in Debian is #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -131,6 +126,11 @@ trait DebianPlugin extends Plugin with linux.LinuxPlugin { | |||
| }, | |||
| debianControlFile <<= (debianPackageMetadata, debianPackageInstallSize, target) map { | |||
| (data, size, dir) => | |||
| if (data.info.description == null || data.info.description.isEmpty) { | |||
There was a problem hiding this comment.
cool. I wonder if we need to consolidate validation errors in one spot at some point. This is a good place right now, but perhaps the debianPackageMetadata can directly have a 'validate' which returns Seq[validatorError] at some point...
There was a problem hiding this comment.
That was my first thought, too. Then I stopped as the PackageMetadata is really a "stupid" information container and the validation if the container is ok, should be done somewhere else.
This should be adressed somehow ;)
|
Thanks for making this nicer! Good to merge after TravisCI reports success. |
muuki88
added a commit
that referenced
this pull request
Feb 1, 2014
Fix #37 Adding meaningful logging, when packageDescription in Debian is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
empty