Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validatePackageConfiguration task #1026

Closed
muuki88 opened this issue Aug 29, 2017 · 0 comments
Closed

Add validatePackageConfiguration task #1026

muuki88 opened this issue Aug 29, 2017 · 0 comments
Assignees
@muuki88
Labels
universal Zip, tar.gz, tgz and bash issues

Comments

@muuki88
Copy link
Contributor

muuki88 commented Aug 29, 2017 •
edited
Loading

Newcomers to native-packager sometimes start a the wrong place, e.g. by googling for a certain solution and copy pasting code from a format documentation page, instead of reading the Getting Started Guide or the readme.md.

Solution

To help the users in different situations we should add a validatePackageConfiguration task that can be implemented by formats and archetypes and provide helpful warnings / errors.

The validation should run by default and can be turned off by overriding the setting.

Examples

  1. If the mappings in Universal is empty, fail validation
  2. If the JavaServerArchetype is enabled and docker is used, emit a warning
  3. If multiple main classes have the same name, fail validation

Related issues:
@muuki88 muuki88 mentioned this issue Sep 25, 2017
Closed
@muuki88 muuki88 added the universal Zip, tar.gz, tgz and bash issues label Nov 1, 2017
@muuki88 muuki88 mentioned this issue Nov 4, 2017
Closed
@muuki88 muuki88 self-assigned this Apr 2, 2018
muuki88 added a commit that referenced this issue Apr 30, 2018
@muuki88
FIX #1026 Add validatePackageConfiguration task
cac3839 
This is an initial draft to provide helpful feedback to users
during their configuration phase with sbt-native-packager.

The intention is to give a short explanation why a warning or
error is triggerd and a detailed description how to fix the issue.
muuki88 added a commit that referenced this issue Apr 30, 2018
@muuki88
FIX #1026 Valiate mappings from linuxPackageMappings
3b82b00
muuki88 added a commit that referenced this issue Aug 24, 2018
@muuki88
FIX #1026 Add validatePackageConfiguration task
fae1f54 
This is an initial draft to provide helpful feedback to users
during their configuration phase with sbt-native-packager.

The intention is to give a short explanation why a warning or
error is triggerd and a detailed description how to fix the issue.
muuki88 added a commit that referenced this issue Aug 24, 2018
@muuki88
FIX #1026 Valiate mappings from linuxPackageMappings
632e738
@retronym retronym mentioned this issue Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muuki88 muuki88

Labels
universal Zip, tar.gz, tgz and bash issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@muuki88