Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sbt/setup-sbt to install sbt + default to zulu@8 #187

Merged
merged 1 commit into from
Jun 23, 2024
Merged

Add sbt/setup-sbt to install sbt + default to zulu@8 #187

merged 1 commit into from
Jun 23, 2024

Conversation

eed3si9n
Copy link
Member

Fixes #185

Problem

  1. Recent runner images no longer have sbt runner scripts installed.
  2. setup-java doesn't have temurin 8 for ARM macOS

Solution

  1. This adds sbt/setup-sbt step to install sbt runner script.
  2. This also defaults to Zulu 8.

@eed3si9n
Add sbt/setup-sbt to install sbt
af45d8f 
**Problem**
1. Recent runner images no longer have sbt runner scripts installed.
2. setup-java doesn't have temurin 8 for ARM macOS

**Solution**
1. This adds sbt/setup-sbt step to install `sbt` runner script.
2. This also defaults to Zulu 8.
This was referenced Jun 23, 2024
Closed
Closed
@eed3si9n eed3si9n changed the title Add sbt/setup-sbt to install sbt Add sbt/setup-sbt to install sbt + default to zulu@8 Jun 23, 2024
mdedetrich
mdedetrich approved these changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill approve this for now. I think there are more principled solutions to (i.e. to me it would be better to use Temurin for every setup aside from Macos ARM JDK 8 and to use Coretta for MacOS ARM JDK 8) but such a setup would be more involved.

@eed3si9n eed3si9n merged commit 636423b into sbt:main Jun 23, 2024
10 checks passed
@eed3si9n eed3si9n deleted the wip/arm branch June 23, 2024 17:25
@mdedetrich
Copy link
Contributor

mdedetrich commented Jun 24, 2024 •
edited
Loading

@eed3si9n Should I release this or are you ontop of it?

@eed3si9n
Copy link
Member Author

I did yesterday

@mzuehlke
Copy link

https://github.com/sbt/sbt-github-actions/releases/tag/v0.24.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdedetrich mdedetrich mdedetrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macos-latest no longer has sbt installed by default
3 participants
@eed3si9n @mdedetrich @mzuehlke