Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use slash syntax everywhere #201

Merged
merged 1 commit into from
Feb 26, 2021
Merged

use slash syntax everywhere #201

merged 1 commit into from
Feb 26, 2021

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Feb 18, 2021 •
edited
Loading

also bump copyright date and remove redundant license section from readme

@SethTisue
Copy link
Member Author

@dwijnand import SlashSyntax._ isn't working here... what's the right import?

@SethTisue
Copy link
Member Author

Dale spotted the problem:

            Global /      sbtVersion  := "1.0.0", // must be Global, otherwise ^^ won't change anything
  LocalRootProject / crossSbtVersions := List("1.0.0"),

LOL

@SethTisue
use slash syntax everywhere
298ffa5 
also bump copyright date and remove redundant license section
from readme
@SethTisue SethTisue force-pushed the slash-syntax-all-the-things branch from 22a618f to 298ffa5 Compare February 26, 2021 17:21
@SethTisue SethTisue marked this pull request as ready for review February 26, 2021 17:21
@SethTisue
Copy link
Member Author

@dwijnand note that CI here is still running on travis-ci.org... time to flip the .com switch

@dwijnand
Copy link
Member

I ran out of credits on my .com profile. So when this inevitably actually stops working on .com I'll finally be forced motivated to learn how to migrate my things to GitHub Actions.

@SethTisue
Copy link
Member Author

ah, I see.

anyway, slooooooooow CI likes it, so this is ready for merge, I believe.

dwijnand
dwijnand approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Seth!

@dwijnand dwijnand merged commit 4d20677 into sbt:master Feb 26, 2021
@SethTisue SethTisue deleted the slash-syntax-all-the-things branch February 26, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SethTisue @dwijnand