defaultUniversalScript that runs under windows and linux #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any Feedback on this? If there is no time for this at the moment this is also okay. |
|
@LolHens Sorry about the delay. |
eed3si9n
requested changes
Apr 13, 2018
There was a problem hiding this comment.
I think it looks good.
Could you update README https://github.com/sbt/sbt-assembly#prepending-shebang too, plz?
|
Okay I updated the readme to reflect the changes. Also I added the javaOpts parameter for the defaultShellScript |
eed3si9n
approved these changes
Apr 15, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a defaultUniversalScript helper method that will generate a script that runs in sh and cmd.
The shebang can be disabled, because in cmd it will display a message saying that "#!" is unrecognized.
Also I added $JAVA_OPTS to defaultShellScript.