Skip to content

Pr gint test#1

Closed
aliabdolali wants to merge 29 commits into
sbrus89:ww3_grid_mod_PRfrom
aliabdolali:PR_gint_test
Closed

Pr gint test#1
aliabdolali wants to merge 29 commits into
sbrus89:ww3_grid_mod_PRfrom
aliabdolali:PR_gint_test

Conversation

@aliabdolali
Copy link
Copy Markdown

As we discussed, I added ww3_multi option to the global unstructured test in this PR. Please merge it and do your test for ww3_tp2.21 cases (both ww3_shel and ww3_multi cases).
For example, you can use the following to do the test.
please do not forget to get the tar file from our ftp at the top directory by executing:
./model/bin/ww3_from_ftp.sh
for intel compiler:

 ./bin/run_test -c intel -S -T -s MPI -s NO_PDLIB -w work_a  -o both -f -p mpirun -n 24 ../model ww3_tp2.21
 ./bin/run_test -c intel -S -T -s MPI -s PDLIB -w work_b -m  -o both -f -p mpirun -n 24 ../model ww3_tp2.21
 ./bin/run_test -c intel -S -T -s MPI -s NO_PDLIB -w work_ma -m grdset_a -o both -f -p mpirun -n 24 ../model ww3_tp2.21
 ./bin/run_test -c intel -S -T -s MPI -s PDLIB -w work_mb -m grdset_b -o both -f -p mpirun -n 24 ../model ww3_tp2.21

sanderh and others added 29 commits July 7, 2020 23:09
to ensure they comply with the limits of the nameslist.
Changes to add support to 360-day and 365-day (no leap year) calendar - see ticket NOAA-EMC#209
  * Additional CALTYPE namelist parameter in MISC section
  * New ww3_tc1 regtest.
* Updated ww3_bound and ww3_bounc to handle model grids formulated on a rotated pole.
* Manual and nml/inp files to updated clarify that ww3_bound/ww3_bounc only accept input spectra formulated on a standard pole grid.
Updates to allow a coupling time step that is different from the model time step. 
* Includes new regtest (in ww3_tp2.14) for non-default oasis time step.
* ww3_tp2.14 regtest added to matrix.base.
* Insertion of the PDLIB stuff.

  Mathieu

* bug in SIGN call when SCRIP is activated

* update SIGN issue

Co-authored-by: Mathieu Dutour Sikiric <Mathieu.Dutour@gmail.com>
Co-authored-by: erdc-tyler.hesser <tyler.hesser@erdc.dren.mil>
@JessicaMeixner-NOAA
Copy link
Copy Markdown

@aliabdolali looking at the PR here, this doesn't make sense to add this to @sbrus89 PR on making ww3_grid into separate a callable subroutine: NOAA-EMC#362

Furthermore, as @sbrus89 use-case for this development is outside the scope of what is tested with ww3 regression tests, and as I don't think we're going to be adding the coupled model tests that @sbrus89 is using, perhaps as long as the current regression tests all pass, this PR: NOAA-EMC#362 can go in as is without additional work.

@sbrus89
Copy link
Copy Markdown
Owner

sbrus89 commented May 3, 2021

@aliabdolali and @JessicaMeixner-NOAA , sorry I missed this amongst all my github emails. I'm happy to test this if necessary.

@JessicaMeixner-NOAA
Copy link
Copy Markdown

@aliabdolali can you please confirm (perhaps by closing this PR) that this PR is not needed and the next step is to just run the regression tests on the original PR to noaa-emc?

@aliabdolali aliabdolali closed this May 3, 2021
@aliabdolali
Copy link
Copy Markdown
Author

@JessicaMeixner-NOAA sure, I agree with your point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants