Fixes to deprecation warnings starting in PHP 8.2 #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `${var}` to embed variables in strings causes warnings starting
in PHP 8.2. This commit replaces two instances with `{$var}`, following
recommendations in the deprecation notice and related RFC.
Calling `reset()` on an object causes warnings starting in PHP 8.2. This commit replaces one instance with ArrayIterator object and getIterator() method following a recommendation in the deprecation notice RFC.
neapsix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Another patch for you to consider. This PR updates a few lines that still work but cause deprecation warnings starting in PHP 8.2.
The first commit replaces
${var}with{$var}. The second uses an iterator instead of callingreset()on an object. I've validated them on FreeBSD with Apache and PHP 8.0, 8.1, and 8.2.I followed the guidance in the deprecation notices but don't have much experience with PHP—happy to change or rework based on your feedback. Thank you so much!
I agree to release this contribution under the Mozilla Public License 2.0.