fix(comments): Links encodage (#1033) #1044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue is that links in comments are being displayed as "$1" instead of the actual URL.
This is caused by how
preg_replace()
is being used in the link processing function.The
$
character is being escaped with a backslash in the replacement pattern, causing PHP to interpret "$1" literally instead of replacing it with the captured reference.Motivation and Context
#1033
How Has This Been Tested?
See repro of #1033
Screenshots (if appropriate):
Types of changes
Checklist: