Person: 'On my list' filter support #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port based on #671 with changes. Co-Authored-By: Alex Perathoner <[email protected]>
|
Amazing, faster is always great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made
Port for 'On my list' checkbox for person page based on #671 with changes.
@AlexPerathoner I moved some stuff around because I was noticing a jitter when untoggling the checkbox on certain pages (actors with long list of credits). I tried a few solution and ended up realising it was probably just something that would be solved when I get time to look at implementing a virtual list wherever we display s.
For now, I changed the code to hide posters with css to avoid the {#each} block triggering again, which seems to have made it faster. I hope you agree with this solution.