Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no filtering tag page and other stuffs i found #633

Merged
merged 10 commits into from
Sep 19, 2024
Merged

Fix no filtering tag page and other stuffs i found #633

merged 10 commits into from
Sep 19, 2024

Conversation

IRHM
Copy link
Member

@IRHM IRHM commented Sep 19, 2024

Changes made

  • Show filter/sort buttons when visiting a tag.
  • WatchedList: Improve 'empty list' error to account for active filters being the cause.
  • Tag: Improve styling of empty tag page error.
  • FilterMenu: Clear filters button, for quickly removing all filters.
  • WatchedList: Clear filters button, for quickly removing all filters, when showing 'empty list' error because of active filters.
  • TagMenu: Fix title text casing.

@IRHM IRHM added bug Hmm, this isn't working correctly enhancement New feature or request labels Sep 19, 2024
@IRHM IRHM self-assigned this Sep 19, 2024
@IRHM IRHM merged commit d3cfc92 into dev Sep 19, 2024
1 check passed
@IRHM IRHM deleted the fix-no-filtering-tag-page branch September 19, 2024 01:29
@IRHM
Copy link
Member Author

IRHM commented Sep 19, 2024

oh yeah closes #621

@IRHM IRHM mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@IRHM IRHM

Labels
bug Hmm, this isn't working correctly enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IRHM