Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recording timeElapsed and add loading state #478

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fix recording timeElapsed and add loading state #478

merged 2 commits into from
Dec 19, 2023

Conversation

IRHM
Copy link
Member

@IRHM IRHM commented Dec 19, 2023

Changes made

  • Fixed recording timeElapsed counting when downloading tools.
  • Added loading state for setup of video recording.

Closes #467

IRHM added 2 commits December 19, 2023 03:48
@IRHM
Recorder: Move isRecording(true) call to after ffmpeg.run call
22e70d1 
This ensures the timer only starts after we start recording - may need to add an intermediary loading state for instant feedback
@IRHM
recorder: change isRecording bool to recordingStatus num
a9c6a82 
3 possible values to allow for a loading state when downloading tools
@IRHM IRHM added the bug Something isn't working label Dec 19, 2023
@IRHM IRHM self-assigned this Dec 19, 2023
@IRHM IRHM merged commit df27ba1 into master Dec 19, 2023
4 checks passed
@IRHM IRHM deleted the fix-timr branch December 19, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@IRHM IRHM

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix recording time elapsed timer counting while downloading ffmpeg/ffprobe
1 participant
@IRHM