Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update draft-ietf-httpbis-rfc6265bis.md #1

Closed
wants to merge 4 commits into from
Closed

Conversation

sbingler
Copy link
Owner

Addressed comments on b0e7653
Moving to a pull request for further review because it makes more sense.

Copy link

@davidben davidben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, but this otherwise LGTM. Thanks!

draft-ietf-httpbis-rfc6265bis.md Outdated Show resolved Hide resolved
draft-ietf-httpbis-rfc6265bis.md Outdated Show resolved Hide resolved
draft-ietf-httpbis-rfc6265bis.md Outdated Show resolved Hide resolved
draft-ietf-httpbis-rfc6265bis.md Show resolved Hide resolved
draft-ietf-httpbis-rfc6265bis.md Outdated Show resolved Hide resolved
client's type, as described in the following subsections:
The request's client's "site for cookies" is either a triple origin or a
globally unique identifier. It is calculated depending upon its client's type,
as described in the following subsections:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some overlap with whatwg/html#4966. No need to do anything now, but when we publish this PR, I think it's worth pointing this out and whether we should align things. (Maybe a request client has a top-level origin plus a "same-site with ancestors" boolean to handle the recursive ancestry business.)

Though it's unclear to me whether this is defining it for a document or a request's client or what.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make a note during the offical PR.

draft-ietf-httpbis-rfc6265bis.md Outdated Show resolved Hide resolved
draft-ietf-httpbis-rfc6265bis.md Outdated Show resolved Hide resolved
worker's "site for cookies" will be the empty string in cases where the values
diverge, and the shared value in cases where the values agree.
worker's "site for cookies" will be a globally unique identifier in cases
where the values diverge, and the shared value in cases where the values agree.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Hopefully we can double-key these so this oddity no longer matters. As things stand, this feature is... kinda weird.)

draft-ietf-httpbis-rfc6265bis.md Outdated Show resolved Hide resolved
draft-ietf-httpbis-rfc6265bis.md Outdated Show resolved Hide resolved
draft-ietf-httpbis-rfc6265bis.md Outdated Show resolved Hide resolved
@sbingler
Copy link
Owner Author

sbingler commented Mar 4, 2021

Closing as this was integrated in via https://github.com/sbingler/cookie-incrementalism

@sbingler sbingler closed this Mar 4, 2021
@sbingler sbingler deleted the sbingler-patch-1 branch September 9, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants