-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update draft-ietf-httpbis-rfc6265bis.md #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments, but this otherwise LGTM. Thanks!
draft-ietf-httpbis-rfc6265bis.md
Outdated
client's type, as described in the following subsections: | ||
The request's client's "site for cookies" is either a triple origin or a | ||
globally unique identifier. It is calculated depending upon its client's type, | ||
as described in the following subsections: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some overlap with whatwg/html#4966. No need to do anything now, but when we publish this PR, I think it's worth pointing this out and whether we should align things. (Maybe a request client has a top-level origin plus a "same-site with ancestors" boolean to handle the recursive ancestry business.)
Though it's unclear to me whether this is defining it for a document or a request's client or what.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make a note during the offical PR.
draft-ietf-httpbis-rfc6265bis.md
Outdated
worker's "site for cookies" will be the empty string in cases where the values | ||
diverge, and the shared value in cases where the values agree. | ||
worker's "site for cookies" will be a globally unique identifier in cases | ||
where the values diverge, and the shared value in cases where the values agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Hopefully we can double-key these so this oddity no longer matters. As things stand, this feature is... kinda weird.)
Closing as this was integrated in via https://github.com/sbingler/cookie-incrementalism |
Addressed comments on b0e7653
Moving to a pull request for further review because it makes more sense.