Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNLE with experimental conditions #829

Merged
merged 3 commits into from
Aug 7, 2023
Merged

MNLE with experimental conditions #829

merged 3 commits into from
Aug 7, 2023

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Apr 5, 2023

changes:

  • rename tutorial 14
  • add new tutorial 17 for iid data in decision-making context: MNLE, and inference with experimental conditions (by conditioning the on the parameters representing the experimental conditions and running MCMC)
  • test for MNLE with experimental conditions
  • add separate train method for MNLE to have the correct return type

@janfb janfb changed the title Mnle conditioning MNLE with experimental conditions Apr 13, 2023
@janfb janfb marked this pull request as ready for review August 4, 2023 08:37
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #829 (68b3a02) into main (86e73a9) will increase coverage by 0.98%.
Report is 21 commits behind head on main.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
+ Coverage   74.59%   75.58%   +0.98%     
==========================================
  Files          80       80              
  Lines        6236     6254      +18     
==========================================
+ Hits         4652     4727      +75     
+ Misses       1584     1527      -57     
Flag Coverage Δ
unittests 75.58% <85.71%> (+0.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sbi/inference/snpe/snpe_c.py 75.36% <0.00%> (ø)
sbi/inference/posteriors/mcmc_posterior.py 85.39% <100.00%> (+0.56%) ⬆️
sbi/inference/snle/mnle.py 85.00% <100.00%> (+1.66%) ⬆️

... and 7 files with indirect coverage changes

Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not read through the new tutorials, but feel free to merge and I'll try to have a look asap.

Thanks!

@janfb janfb merged commit e7f07bb into main Aug 7, 2023
1 check passed
@janfb janfb deleted the mnle-conditioning branch August 7, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants