Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tutorials test error handling, fix bugs in tutorials #1264

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Sep 4, 2024

Fixes error handling in tutorial_tests.py by calling RunTimeError explicitly.

Fixes two API bugs in tutorials 7, 12, 15 and 18.

Refactor tutorial 18.

@janfb janfb self-assigned this Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.31%. Comparing base (8afd985) to head (e8391dd).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1264      +/-   ##
==========================================
- Coverage   86.05%   78.31%   -7.75%     
==========================================
  Files         118      119       +1     
  Lines        8672     8697      +25     
==========================================
- Hits         7463     6811     -652     
- Misses       1209     1886     +677     
Flag Coverage Δ
unittests 78.31% <ø> (-7.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

@janfb janfb changed the title fix: tutorials test error handling, fix tutorial 7 fix: tutorials test error handling, fix tutorials 7, 12, 15, 18 Sep 5, 2024
@janfb janfb changed the title fix: tutorials test error handling, fix tutorials 7, 12, 15, 18 fix: tutorials test error handling, fix bugs in tutorials Sep 5, 2024
Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@janfb janfb merged commit a4f7811 into main Sep 5, 2024
6 of 7 checks passed
@janfb janfb deleted the fix-tutorials-test branch September 5, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants