Test new docker workflow #46
Open
+41
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
=======================================
Coverage 97.29% 97.29%
=======================================
Files 17 17
Lines 1701 1701
=======================================
Hits 1655 1655
Misses 46 46 |
2 tasks
sbfnk
reviewed
Sep 5, 2023
| @@ -14,6 +14,9 @@ jobs: | |||
| container: ghcr.io/bisaloo/libbi-docker:main | |||
| name: docker | |||
| env: | |||
| # Avoid interaction requests from apt. It's better to set it here than in | |||
| # the Docker img: https://github.com/moby/moby/issues/4032 | |||
| DEBIAN_FRONTEND: noninteractive | |||
There was a problem hiding this comment.
Might be a problem that it's not passed to the sudo env in https://github.com/sbfnk/rbi/actions/runs/6081518618/job/16497330229#step:5:1481?
A (not hugely satisfactory) solution might be to install tzdata in the docker image instead.
This reverts commit 97141e1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.