Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page attribute doesn't work #67

Closed
jcampalo opened this issue Nov 19, 2015 · 1 comment · Fixed by #68
Closed

Page attribute doesn't work #67

jcampalo opened this issue Nov 19, 2015 · 1 comment · Fixed by #68
Assignees
Labels

Comments

@jcampalo
Copy link

There is a issue with page attribute, whatever you do is overwritten to page one when the directive is initialized, you can see it in the example of the project.

@simobasso
Copy link
Collaborator

Hi @jcampalo, thanks, you have right!

I try to patch today.

@simobasso simobasso added the bug label Nov 19, 2015
@simobasso simobasso self-assigned this Nov 19, 2015
simobasso added a commit to simobasso/angularjs-pdf that referenced this issue Nov 19, 2015
- [X] use more verbose `pageToDisplay` instead `pageNum`
- [X] on init use `pageToDiplay` instead 1
- [X] add a check on parse the attrs to ensure it's an int (else fallback to 1)

fix sayanee#67
jcampalo pushed a commit to jcampalo/angularjs-pdf that referenced this issue Nov 19, 2015
simobasso added a commit to simobasso/angularjs-pdf that referenced this issue Nov 19, 2015
- [X] use more verbose `pageToDisplay` instead `pageNum`
- [X] on init use `pageToDiplay` instead 1
- [X] add a check on parse the attrs to ensure it's an int (else fallback to 1)

fix sayanee#67
sayanee added a commit that referenced this issue Nov 19, 2015
@sayanee sayanee mentioned this issue Nov 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants