Skip to content

Commit 23f1de4

Browse files
committed
Merge pull request #68 from simobasso/pageNum_fix
fix angular-pdf: patch issue #67
2 parents 6362966 + 1c963ec commit 23f1de4

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

dist/angular-pdf.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
link: function(scope, element, attrs) {
3737
var url = scope.pdfUrl;
3838
var pdfDoc = null;
39-
var pageNum = (attrs.page ? attrs.page : 1);
39+
var pageToDisplay = isFinite(attrs.page) ? parseInt(attrs.page) : 1;
4040
var pageFit = attrs.scale === 'page-fit';
4141
var scale = attrs.scale > 0 ? attrs.scale : 1;
4242
var canvasid = attrs.canvasid || 'pdf-canvas';
@@ -53,7 +53,7 @@
5353
});
5454

5555
PDFJS.disableWorker = true;
56-
scope.pageNum = pageNum;
56+
scope.pageNum = pageToDisplay;
5757

5858
scope.renderPage = function(num) {
5959
if (renderTask) {
@@ -190,7 +190,7 @@
190190
if (newVal !== '') {
191191
console.log('pdfUrl value change detected: ', scope.pdfUrl);
192192
url = newVal;
193-
scope.pageToDisplay = 1;
193+
scope.pageToDisplay = pageToDisplay;
194194
if (pdfLoaderTask) {
195195
pdfLoaderTask.destroy().then(function () {
196196
renderPDF();

dist/angular-pdf.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example/js/directives/angular-pdf.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
link: function(scope, element, attrs) {
3737
var url = scope.pdfUrl;
3838
var pdfDoc = null;
39-
var pageNum = (attrs.page ? attrs.page : 1);
39+
var pageToDisplay = isFinite(attrs.page) ? parseInt(attrs.page) : 1;
4040
var pageFit = attrs.scale === 'page-fit';
4141
var scale = attrs.scale > 0 ? attrs.scale : 1;
4242
var canvasid = attrs.canvasid || 'pdf-canvas';
@@ -53,7 +53,7 @@
5353
});
5454

5555
PDFJS.disableWorker = true;
56-
scope.pageNum = pageNum;
56+
scope.pageNum = pageToDisplay;
5757

5858
scope.renderPage = function(num) {
5959
if (renderTask) {
@@ -190,7 +190,7 @@
190190
if (newVal !== '') {
191191
console.log('pdfUrl value change detected: ', scope.pdfUrl);
192192
url = newVal;
193-
scope.pageToDisplay = 1;
193+
scope.pageToDisplay = pageToDisplay;
194194
if (pdfLoaderTask) {
195195
pdfLoaderTask.destroy().then(function () {
196196
renderPDF();

0 commit comments

Comments
 (0)