Changes#1
Merged
toots merged 6 commits intosavonet:masterfrom Jul 19, 2021
Merged
Conversation
Using the `caml_` prefix here is unlikely to cause any problem at all as the library really uses `caml_winsvc_`, however it's better not to use the prefix at all.
dra27
reviewed
Apr 29, 2021
dra27
left a comment
dra27
left a comment
There was a problem hiding this comment.
I'd just use Failure _, or possibly even Not_found - it's a uniquely useful error (as in you might do something other than terminate with it)
| report_status(SERVICE_STOPPED, NO_ERROR, 2000); | ||
| } | ||
|
|
||
| #define raise_error(str) caml_raise_with_string(*caml_named_value("caml_service_exn"), str) |
There was a problem hiding this comment.
Fixes a bug as well - "caml_service_exn" here but "caml_winsvc_exn" above
If StartServiceCtrlDispatcher() returns ERROR_FAILED_SERVICE_CONTROLLER_CONNECT, then the program is being run as a console application rather than as a service. Not using Winsvc.Error helps identifying this special case.
Collaborator
Author
|
Applied your suggestions, thanks! |
Member
|
This all looks great! My only remark is w.r.t. to the namespace. Liqiudsoap is built statically and I try to be on the most safe side I can with potentiasl symbol name clashes. I agree on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This PR introduces fixes and some changes:
caml_winsvc_prefix but onlywinsvc_ascaml_is reserved by OCaml standard library;Let me know what you think!