TLS1_3_VERSION must be ifdef'ed#69
Closed
lindig wants to merge 1 commit into
Closed
Conversation
|
#63 has a same change as well. |
Symbol TLS1_3_VERSION is not available in all openssl releases and therefore must be ifdef'ed to avoid compilation error. Signed-off-by: Christian Lindig <christian.lindig@citrix.com>
Author
|
That fix is actually more comprehensive - so we can disregard my pull request. |
Contributor
|
This change was merged in #73 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symbol TLS1_3_VERSION is not available in all openssl releases and
therefore must be ifdef'ed to avoid a compilation error.
This is just a quick fix. I believe the correct thing to do is to use
HAVE_TLS13et al. to guard each of the cases in this match.Signed-off-by: Christian Lindig christian.lindig@citrix.com