Feat: Implement basic semantic highlighting for functions and variables #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
WilsonZiweiWang
commented
Sep 28, 2023
•
WilsonZiweiWang
commented
- Match function and variable declarations
- Match function and variable references
- References are matched only if they are declared first
- Currently it doesn't care about the scope, tokens are generated as long as they are matched by the regex
1. Match function and variable declarations 2. Match function and variable references 3. References are matched only if they are declared first 4. Currently it doesn't about the scope, tokens are generated as long as they are matched by the regex
|
Example of results: |
idillon-sfl
reviewed
Sep 29, 2023
|
Digits are also not supported as first characters in function and variable names |
idillon-sfl
approved these changes
Sep 29, 2023
1. Remove digits as possible first character and hypen in the function and variable names 2. Enable grammars for numeric and square brackets in variable expansion syntax
…ction and variable names
Removed digits as possible first character and hyphen in the function and variable names |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.