-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor, add variables from yocto docs, add hover definition for yocto docs, etc #59
Refactor, add variables from yocto docs, add hover definition for yocto docs, etc #59
Conversation
@deribaucourt |
Here's an idea: We could eventually add an option to select between "yocto" mode and "pure bitbake" mode. But as it seems nobody cares about "pure bitbake" mode, maybe we could stick to the "yocto" mode until there's a demand for it. |
I wouldn't say nobody cares about "pure bitbake", but yes they are extremly rare. Our extension addressing the broader public should focus on Yocto. |
Do you have example variable definitions being duplicated? I'd like to compare them to tell you which is better. Picking any of the two is already fine for this PR. Duplication may very well be addressed in the Yocto documentation itself. |
9d2e9c8
to
a4b7611
Compare
|
The Yocto documentation is more complete. You should only provide it when the bitbake doc collides. |
1. Rename members 2. Add new types for doc info 3. Only store doc info in the class, the conversion to completion item happens in onCompletion handler
1. Add tests from hover definition for yocto tasks 2. Hover definition tests now scann the docs before compare results 3. Completion tests also include the ones that need doc scan
a4b7611
to
f40fb0f
Compare
Refactored the bitbakeDocScanner. It won't store completion items. The conversion happens in
onCompletion
handler.Added variables from yocto docs.
![image](https://private-user-images.githubusercontent.com/47988425/281205367-66683318-9799-4a97-9027-535afcdfcec4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3OTc2MDMsIm5iZiI6MTczOTc5NzMwMywicGF0aCI6Ii80Nzk4ODQyNS8yODEyMDUzNjctNjY2ODMzMTgtOTc5OS00YTk3LTkwMjctNTM1YWZjZGZjZWM0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE3VDEzMDE0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA3MjQ4NmNiYjdkOTUyOTU4MzU3OTg3ODYxNTFkMmNjYTA0ZTY1NzRjODdmODBiMjZjYTI5NTI4MjJkMjQ2NDcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.yJRV8rHOCYSp_X_NHrgRwuO-mw1DNr-UPlMvajxsumo)
Added hover definition for yocto tasks.
![image](https://private-user-images.githubusercontent.com/47988425/281205317-a41f8c4a-7ad0-4f76-bea2-803d2dce7f9a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3OTc2MDMsIm5iZiI6MTczOTc5NzMwMywicGF0aCI6Ii80Nzk4ODQyNS8yODEyMDUzMTctYTQxZjhjNGEtN2FkMC00Zjc2LWJlYTItODAzZDJkY2U3ZjlhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE3VDEzMDE0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgyNjg2ZmM4NjEzMGFjODlhNTE0YTY5OWRlMzAwN2UzODY3NzI1MjVjYTA0N2Y5ZTlmMzQ5MzFlZDJlNzg1NmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.FZMLFGjkCoNF_Mv1peoNj5T77KjcccEZhIq6FxiFQQE)
Updated the tests.