Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Replace pn-defaultpkgname with ${PN} #57

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

deribaucourt
Copy link
Member

The overrides are scanned using no specific recipe. The corresponding package override, pn-defaultpkgname does not exist in this case. Commonly, ${PN} is used instead.

The overrides are scanned using no specific recipe. The corresponding
package override, pn-defaultpkgname does not exist in this case. Commonly,
${PN} is used instead.
@rossburton
Copy link

Inside a recipe you'd never use pn-${PN} as there's no point: you're already in recipe-scope.

Outside of a recipe you'd need to use the full recipe name, not PN.

So maybe just remove pn-defaultpkgname>

@deribaucourt
Copy link
Member Author

deribaucourt commented Nov 7, 2023

Inside a recipe you'd never use pn-${PN} as there's no point: you're already in recipe-scope.

@rossburton With this PR, we just suggest ${PN}, it's very useful when defining the FILES variable for instance:
image

Outside of a recipe you'd need to use the full recipe name, not PN.

So maybe just remove pn-defaultpkgname>

Yeah it doesn't makes that much sense outside of a recipe. Yet theoretically I think it can be used in .inc/.bbclass files to refer to the actual PN that will be used by the recipes. If this suggestion really hurts hurts, we may add logic to detect if we're in a .conf file to disable it.

Otherwise, I think ${PN} is a valuable as suggestion in general like in the FILES variable example.

@deribaucourt deribaucourt merged commit aed0d73 into staging Nov 8, 2023
3 checks passed
@deribaucourt deribaucourt deleted the pn-override branch November 8, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants