Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Generated bitbake task names #49

Merged
merged 1 commit into from
Nov 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions client/src/ui/BitbakeCommands.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ async function buildRecipeCommand (bitbakeWorkspace: BitbakeWorkspace, taskProvi
const task = new vscode.Task(
{ type: 'bitbake', recipes: [chosenRecipe] },
vscode.TaskScope.Workspace,
`Run bitbake ${chosenRecipe}`,
`Build recipe: ${chosenRecipe}`,
'bitbake'
)
await runBitbakeTask(task, taskProvider)
Expand All @@ -41,7 +41,7 @@ async function cleanRecipeCommand (bitbakeWorkspace: BitbakeWorkspace, taskProvi
const task = new vscode.Task(
{ type: 'bitbake', recipes: [chosenRecipe], task: 'clean' },
vscode.TaskScope.Workspace,
`Run bitbake ${chosenRecipe}`,
`Clean recipe: ${chosenRecipe}`,
'bitbake'
)
await runBitbakeTask(task, taskProvider)
Expand All @@ -62,7 +62,7 @@ async function runTaskCommand (bitbakeWorkspace: BitbakeWorkspace, taskProvider:
const task = new vscode.Task(
{ type: 'bitbake', recipes: [chosenRecipe], task: chosenTask },
vscode.TaskScope.Workspace,
`Run bitbake ${chosenRecipe} -c ${chosenTask}`,
`Run task ${chosenTask} for ${chosenRecipe}`,
'bitbake'
)
await runBitbakeTask(task, taskProvider)
Expand Down
6 changes: 3 additions & 3 deletions client/src/ui/BitbakeTaskProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ export class BitbakeTaskProvider implements vscode.TaskProvider {
const bitbakeTaskDefinition: BitbakeTaskDefinition = task.definition as any
if (bitbakeTaskDefinition.recipes?.[0] !== undefined) {
const resolvedTask = new vscode.Task(
bitbakeTaskDefinition,
task.definition,
task.scope ?? vscode.TaskScope.Workspace,
`Run bitbake -c ${bitbakeTaskDefinition.task ?? 'build'} ${bitbakeTaskDefinition.recipes.join(' ')}`,
'bitbake',
task.name,
task.source ?? 'bitbake',
new vscode.CustomExecution(async (resolvedDefinition: vscode.TaskDefinition): Promise<vscode.Pseudoterminal> =>
new BitbakeBuildTaskTerminal(this.composeBitbakeCommand(bitbakeTaskDefinition), this.bitbakeDriver)),
['$bitbake-ParseError', '$bitbake-Variable', '$bitbake-generic']
Expand Down
Loading