Refactor to a common bitbake lib #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deribaucourt
force-pushed
the
bitbake-lib
branch
2 times, most recently
from
5d576fe
to
12b7cc0
Compare
deribaucourt
force-pushed
the
bitbake-lib
branch
4 times, most recently
from
fd2399a
to
cc3c0fa
Compare
deribaucourt
force-pushed
the
bitbake-lib
branch
2 times, most recently
from
710eec0
to
08ba592
Compare
deribaucourt
force-pushed
the
bitbake-lib
branch
3 times, most recently
from
a96b328
to
ac74ea7
Compare
Allow the client and server to share common code. In order to comply with VSCode packaging, the code is compiled both in the server and the client outputs. A package.json is only provided to install common dependencies. Unit tests, linting and debugging configurations were tested and updated to work with the new structure.
This code was produced just to check through the CI that everything was included properly while providing a usage example.
In order to be able to log from that library, the logger must be within it. vscode cannot be imported from the language server so we use dependency inversion to now pass the output channel to the logger.
OutputLogger was moved to the common lib directory, update all references.
In order to share this between the language client and server, it must be in the common library. Because vscode cannot be imported in the server, the settings must be passed in from the client. We use the any type as this is what's produced by vscode.workspace.getConfiguration in both the client and server. Tests and references are also updated.
The server bitbake scanner usually wants to wait for the bitbake command to finish.
This makes the language server use the same Bitbake implementation as the client. Common duplicated code is now refactored into a single library.
The bitbake scanner provides the list of active overrides. It is not recipe specific to be faster.
Add an integration test that runs bitbake and ensures we properly parse the result to collect statistics about the project.
The Bitbake scanner would only fail when bitbake succeeded and produced an output.
deribaucourt
force-pushed
the
bitbake-lib
branch
from
ac74ea7
to
d95a95f
Compare
WilsonZiweiWang
approved these changes
Nov 2, 2023
idillon-sfl
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new and more complete bitbakeDriver from the client in the language server.