Add client tests #29
Add client tests #29
Conversation
deribaucourt
force-pushed
the
add-client-tests
branch
2 times, most recently
from
41bc82a
to
4657d51
Compare
deribaucourt
force-pushed
the
add-client-tests
branch
from
a7b43c8
to
6790ef2
Compare
| // under MIT License | ||
|
|
||
| const languages = { | ||
| createDiagnosticCollection: jest.fn(), |
There was a problem hiding this comment.
As discussed in another comment, I suggest keeping the original file and not changing it's linting rules.
| Default: 0, | ||
| }; | ||
|
|
||
| export = { |
There was a problem hiding this comment.
On my side typescript complains it is using the CommonJS syntax, while the EcmaScript syntaxt should be used (export default). Yet it won't compile if I make that change.
I am not sure where is exactly the problem, but I noticed .eslintrc.js is also using a commonjs export. I also noticed you put this file into "ignorePatterns". I am thinking this was an attempt to solve that problem.
There was a problem hiding this comment.
This file comes from another repo and works fine. As long as we don't change it, it makes no sense to me to test it's linting, which follows a different standard in another project. Also it makes it easy to update this file in the future when the vscode API changes/adds new features. I suggest to ignore linting this file and keep it as original. A comment at the top clearly indicates where it comes from.
There was a problem hiding this comment.
Makes sense. However I am surprised it works. Both syntaxes are not supposed to be interchangeable within a project. As a proof, this file does not compile if you use the ecmascript syntax. It makes me think the "root project" is not configured properly.
deribaucourt
force-pushed
the
add-client-tests
branch
3 times, most recently
from
10013d5
to
fcbd549
Compare
Using the Jest extension in VSCode, it is now possible to run, watch and debug jest tests.
Add a dummy test to make sure the client test suite is working.
In order to make the class testable, we will need to mock vscode before the global instance is created.
This is a mock of the VSCode API that is used by the Jest extension. It is copied from the jest-community/vscode-jest project, which is licensed under the MIT license.
The eslint plugin is also added to package.json. package-lock.json is updated with npm 20.8.0.
deribaucourt
force-pushed
the
add-client-tests
branch
from
fcbd549
to
f506c24
Compare
The package*.json where updated with node 20.8.0.
Allows debugging the tests through the VSCode debugger. It was already possible through the Jest extension.
deribaucourt
force-pushed
the
add-client-tests
branch
from
f506c24
to
a2f0eaf
Compare
| connection.onInitialize(async (params): Promise<InitializeResult> => { | ||
| const workspaceRoot = params.rootPath ?? '' | ||
| connection.onInitialize(async (params: InitializeParams): Promise<InitializeResult> => { | ||
| const workspaceRoot = params.workspaceFolders?.[0]?.uri ?? '' |
There was a problem hiding this comment.
I think it is possible that users have multiple folders opened in one workspace and all of them are bitbake projects.
No description provided.