Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for textmate grammars #10

Merged

Conversation

WilsonZiweiWang
Copy link
Collaborator

@WilsonZiweiWang WilsonZiweiWang commented Sep 29, 2023

@WilsonZiweiWang WilsonZiweiWang marked this pull request as draft September 29, 2023 22:56
@WilsonZiweiWang WilsonZiweiWang self-assigned this Sep 29, 2023
1. Add files for creating snapshots of the grammars
2. Separate the test cases according to the category.
3. Test cases only care about grammars related to their category, ensuring other broken grammars won't break the tests
@WilsonZiweiWang WilsonZiweiWang force-pushed the Feature-10094-Improve-syntax-parser-Add-test branch from c364224 to 62e6e0b Compare October 2, 2023 22:24
@WilsonZiweiWang WilsonZiweiWang added enhancement New feature or request help wanted Extra attention is needed labels Oct 2, 2023
@WilsonZiweiWang WilsonZiweiWang marked this pull request as ready for review October 2, 2023 22:25
@WilsonZiweiWang
Copy link
Collaborator Author

To inspect the scopes, find and run this command in VS Code command palette:
Developer: Inspect Editor Tokens and Scopes

Copy link
Member

@deribaucourt deribaucourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very impressive

@WilsonZiweiWang WilsonZiweiWang merged commit 1bed1e7 into staging Oct 3, 2023
@WilsonZiweiWang WilsonZiweiWang deleted the Feature-10094-Improve-syntax-parser-Add-test branch October 23, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants