Flush unused methods and tests #845
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manumilou
commented
Apr 4, 2019
| total_quantity=1, | ||
| remark='no sugar') | ||
| response = self.client.get('/delivery/kitchen_count/') | ||
| self.assertTrue(b'Compote' in response.content) |
There was a problem hiding this comment.
I removed the entire test, as this is the only assertion. That's a lot of setup for a single test.
| @@ -39,35 +39,6 @@ def setUpTestData(cls): | |||
| """ | |||
| cls.order = OrderFactory(order_item=None) | |||
|
|
|||
| def test_order_add_item_meal_component(self): | |||
There was a problem hiding this comment.
I did not remove the entire test class, as it is reused later in this test file. But, effectively, there is no more test in this class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackles #842
It turns out that
add_itemis not used, so the clients are always billed with the proper prices. It must have been part of a refactoring initiative that did not finish.Changes proposed in this pull request:
🔥
add_item,remove_itemandcancelmethodsremove_itemandcancelwere not tested.Status
Additional notes
I let you decide if you want to merge that or not. In my opinion, it's better to remove dead code, as it can lead to confusion.