Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile shouldn't use ADD #755

Closed
kousu opened this issue Jun 23, 2017 · 3 comments
Closed

Dockerfile shouldn't use ADD #755

kousu opened this issue Jun 23, 2017 · 3 comments

Comments

@kousu
Copy link

kousu commented Jun 23, 2017 •
edited
Loading

The Dockerfile right now says

ADD requirements.txt /code/
...
ADD . /code/

https://docs.docker.com/engine/reference/builder/#add doesn't make it that clear, but https://www.ctl.io/developers/blog/post/dockerfile-add-vs-copy/ suggests that ADD is almost always a mistake and that COPY is correct.
@lingxiaoyang
Copy link
Contributor

@erozqba After reading the doc, I think we can simply replace AND with COPY?

@erozqba
Copy link
Contributor

erozqba commented Jun 28, 2017

@lingxiaoyang yes.

erozqba added a commit to erozqba/sous-chef that referenced this issue Jun 28, 2017
@erozqba
Replace ADD with COPY in Dockerfile.
864e6d2 
Ref: issue savoirfairelinux#755
@erozqba erozqba mentioned this issue Jun 28, 2017
Merged
5 tasks
@lingxiaoyang
Copy link
Contributor

Merged in #774.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kousu @lingxiaoyang @erozqba