Crypto: move ops to Value #357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmarOk1412
reviewed
Dec 11, 2018
AmarOk1412
reviewed
Dec 11, 2018
| } | ||
| } | ||
| if (v->isSigned()) | ||
| return v->checkSignature(); |
There was a problem hiding this comment.
No more log if checkSignature fails "Signature verification failed"
| } | ||
| if (!n->signatureValid) { | ||
| DHT_LOG.WARN("Edition forbidden: signature verification failed."); | ||
| if (not n->checkSignature()) |
AmarOk1412
reviewed
Dec 11, 2018
| signatureChecked = true; | ||
| if (isSigned()) { | ||
| signatureValid = owner and owner->checkSignature(getToSign(), signature); | ||
| } else { |
There was a problem hiding this comment.
Remove this block for homogeneization
|
Else it's ok for me |
aberaud
force-pushed
the
master
branch
9 times, most recently
from
f05b60d
to
dfd0a09
Compare
aberaud
force-pushed
the
master
branch
13 times, most recently
from
85204fa
to
966e620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.