Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Bangla language support to num2word for Bangladesh. #589

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

matrosdzmehedi
Copy link
Contributor

Changes proposed in this pull request:

  • This adds Bangla language support and Num2Word conversion functionality for the Bangladesh .
  • Added support for Bangla language ("bn" code).
  • Added Test for Bangla language.

Status

  • [ X] READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

run test for verification.

@matrosdzmehedi
Copy link
Contributor Author

Can you please re-run the CI . I have fixed the isort and flake8 issues.

@coveralls
Copy link

coveralls commented Oct 17, 2024

Coverage Status

coverage: 98.051% (+0.05%) from 97.998%
when pulling 56cba58 on matrosdzmehedi:master
into 2ab2667 on savoirfairelinux:master.

@matrosdzmehedi
Copy link
Contributor Author

idk, why coverage is failing I have my files are cover 99% with test. Can you merge this PR and see coverage after merge.

@matrosdzmehedi
Copy link
Contributor Author

I may have same issue as this PR:

#574

@matrosdzmehedi
Copy link
Contributor Author

@SkiBY can you review and run ci and workflow.

@matrosdzmehedi
Copy link
Contributor Author

@SkiBY can you help me ,
How this import make less coverage??

file: num2words/init.py
from . import (lang_AM, lang_AR, lang_AZ, lang_BE, lang_BN ..... so on
I just add lang_BN

and

CONVERTER_CLASSES = {
'am': lang_AM.Num2Word_AM(),
'ar': lang_AR.Num2Word_AR(),
'az': lang_AZ.Num2Word_AZ(),
'be': lang_BE.Num2Word_BE(),
'bn': lang_BN.Num2Word_BN(), this line making less coverage ??

@SkiBY
Copy link
Contributor

SkiBY commented Nov 5, 2024

@SkiBY can you help me , How this import make less coverage??

Coverage tests are a little bit unfair. Your coverage is marked as 100%, so you could help to increase a coverage for some languages you know.

@matrosdzmehedi
Copy link
Contributor Author

It's tough to understand other countries native . So It would not be much help if I write test which I don't understand !

@mrodriguezg1991 mrodriguezg1991 merged commit f503d8c into savoirfairelinux:master Nov 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants