Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Czech ISO code cs to converter classes #571

Closed
wants to merge 1 commit into from

Conversation

comodoro
Copy link

Fixes # by...

Changes proposed in this pull request:

Add Czech language ISO code cs to converter classes For compatibility at least with gruut

Status

  • [X ] READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

Additional notes

I am playing witn Coqui TTS and gettingNotImplementedError because of this

For compatibility at least with gruut
@coveralls
Copy link

Coverage Status

coverage: 97.561%. remained the same
when pulling 45d7ee2 on comodoro:patch-1
into 5e6fa94 on savoirfairelinux:master.

@comodoro
Copy link
Author

I have just used the original repo, the exceptions are

Failed to convert number 22 to words for language cs-cz
Traceback (most recent call last):
  File "/home/vojta/tts/venv/lib/python3.10/site-packages/gruut/text_processor.py", line 2086, in _verbalize_number
    num_str = num2words(final_num, **num2words_kwargs)
  File "/home/vojta/tts/venv/lib/python3.10/site-packages/num2words/__init__.py", line 91, in num2words
    raise NotImplementedError()
NotImplementedError
Failed to convert number 22 to words for language cs-cz
Traceback (most recent call last):
  File "/home/vojta/tts/venv/lib/python3.10/site-packages/gruut/text_processor.py", line 2086, in _verbalize_number
    num_str = num2words(final_num, **num2words_kwargs)
  File "/home/vojta/tts/venv/lib/python3.10/site-packages/num2words/__init__.py", line 91, in num2words
    raise NotImplementedError()
NotImplementedError
Failed to convert number 1963 to words for language cs-cz
Traceback (most recent call last):
  File "/home/vojta/tts/venv/lib/python3.10/site-packages/gruut/text_processor.py", line 2086, in _verbalize_number
    num_str = num2words(final_num, **num2words_kwargs)
  File "/home/vojta/tts/venv/lib/python3.10/site-packages/num2words/__init__.py", line 91, in num2words
    raise NotImplementedError()
NotImplementedError
[...]

@TrangOul
Copy link
Contributor

"CZ" is wrong, it should be replaced. Done in #587.

@mrodriguezg1991
Copy link
Contributor

Thanks for raising the issue
Updated on #587
i will close this PR, if you have any other problems do not hesitate on commenting or creating new PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants