Rule 6.1.1 Primary constructor should be defined implicitly in the declaration of class

[petertrr]

Which rule and warnings did you add?

This pull request closes #429

Actions checklist

• Implemented Rule, added Warnings
• Added tests on checks
• Added tests on fixers
• Updated diktat-analysis.yml
• Updated available-rules.md

Fixme

• more complicated cases for fixing
• keep modifiers and annotations from secondary constructor

[codecov]

Codecov Report

Merging #435 into master will decrease coverage by 0.06%.
The diff coverage is 80.53%.

@@             Coverage Diff              @@
##             master     #435      +/-   ##
============================================
- Coverage     81.83%   81.76%   -0.07%     
- Complexity     1501     1528      +27     
============================================
  Files            71       72       +1     
  Lines          3765     3861      +96     
  Branches       1209     1234      +25     
============================================
+ Hits           3081     3157      +76     
  Misses          210      210              
- Partials        474      494      +20     

Flag	Coverage Δ	Complexity Δ
unittests	81.76% <80.53%> (-0.07%)	0.00 <27.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
...at-rules/src/main/kotlin/generated/WarningNames.kt	0.00% <ø> (ø)	0.00 <0.00> (ø)
...qfn/diktat/ruleset/utils/search/VariablesSearch.kt	89.28% <ø> (ø)	19.00 <0.00> (ø)
...tat/ruleset/rules/classes/SingleConstructorRule.kt	78.02% <78.02%> (ø)	26.00 <26.00> (?)
...tlin/org/cqfn/diktat/ruleset/utils/KotlinParser.kt	86.00% <90.00%> (+0.89%)	19.00 <1.00> (+1.00)
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt	98.21% <100.00%> (+0.01%)	10.00 <0.00> (ø)
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt	97.01% <100.00%> (+0.04%)	8.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f47a76...5f6ab69. Read the comment docs.

[orchestr7]

some things need clarification

[orchestr7]

what will you do - if there are no secondaryConstructors?

[petertrr]

Nothing, as there is nothing to convert,

[orchestr7]

I started thinking that there can be issues right now:

constructor(a: Int) {
    val f = F(a)
    this.a = f.foo()
}

how it should work?

[petertrr]

I think we can't reliably automate complex cases. Your example will be converted to

class Foo(val a: Int) {
    init {
        f = F(a)
    }
}

and it will break the code. In my opinion, correct form of this code should be

class Foo(a: Int) {
    val a: Int by lazy {
        val f = F(a)
        f.foo()
    }
}

but there may be other valid cases for refactoring.

[orchestr7]

please add a Kdoc with a fixme for it

[orchestr7]

lgtm