Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the missing fat JAR problem during the release procedure #1479

Merged
merged 2 commits into from
Jul 27, 2022
+10 −4
Merged

Fix the missing fat JAR problem during the release procedure #1479

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
313888f
Fix the missing fat JAR problem during the release procedure
0x6675636b796f75676974687562 Jul 27, 2022
7f14cf0
Correct the comment
0x6675636b796f75676974687562 Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,16 @@ jobs:
{ "id": "gpg.passphrase", "passphrase": "${{ secrets.DIKTAT_GPG_PASS }}" },
{ "id": "kotlin-maven-plugin-tools", "username": "${{github.actor}}", "password": "${{ secrets.GITHUB_TOKEN }}" }
]
- name: Deploy artifacts
run: mvn -B clean deploy -Prelease --projects '!diktat-ruleset'
- name: Build diktat.jar
run: mvn -B package --projects diktat-ruleset
# Runs tests, incl. smoke tests (using a fat JAR built from the
# "diktat-ruleset" module). The fat JAR is also used later during the
# "upload-release-asset" step (see below).
- name: Run tests
run: mvn -B clean install
# "diktat-ruleset" is a module that creates a fat JAR, which is,
# obviously, never released. Since we *do need* this fat JAR in order to
0x6675636b796f75676974687562 marked this conversation as resolved.
Show resolved Hide resolved
# run smoke tests, we *skip tests entirely* in this step.
- name: Deploy artifacts (skipping the clean, test, and verify phases)
run: mvn -B deploy -Prelease --projects "!diktat-ruleset" -DskipTests=true
- name: Create Github Release
id: create_release
uses: actions/create-release@v1
Expand Down